search

kohler / click

The Click modular router: fast modular packet processing and analysis
Other
740 stars 321 forks source link

fix segfault #370

Closed larsbro closed 6 years ago

larsbro commented 6 years ago

Fixes a segfault that occurs if pcap_activate() returns an error. Return immediately instead of proceeding with pcap_setnonblock()...

bcronje commented 6 years ago

I believe there is already another pull request for this fix, see https://github.com/kohler/click/pull/355

Not sure why it has not been merged.

larsbro commented 6 years ago

That is right, #355 seems to be the same. If that is really so, then we can leave this one out.

larsbro commented 6 years ago

The strange thing is that CI wont build, while #355 has come through all checks, even if it is the same. I will close this one then, and wait for #355 to be merged.

tbarbette commented 6 years ago

FYI, CI is broken per another test, not yours.