kohler / hotcrp

HotCRP conference review software
http://read.seas.harvard.edu/~kohler/hotcrp
Other
321 stars 109 forks source link

Reviewform checkboxes are not rendered correctly for single boxes # 7+ #306

Closed hi-liang closed 1 year ago

hi-liang commented 1 year ago

https://github.com/kohler/hotcrp/blob/c9cfc87fd80c54c69dc03bcb20e8a748a84f60b3/src/reviewfields/rf_checkboxes.php#L44

When doing bitwise comparison (for checkboxes larger than MASK2SCORE range), the unpack_value_symbols function should be looping while $b <= $fval just like in unpack_value above it.

Currently if we have only box # 7 checked, for instance, the corresponding $fval of 64 will never be reached and the checkboxes field returns empty array, rendered as None

kohler commented 1 year ago

Thanks, fixed in b21da2cd1!

hi-liang commented 1 year ago

Great thanks!