search

kohler / hotcrp

HotCRP conference review software
http://read.seas.harvard.edu/~kohler/hotcrp
Other
328 stars 111 forks source link

feature request: review diffs #320

Open PeterSewell opened 1 year ago

PeterSewell commented 1 year ago

It'd be really useful to be able to see the changes when reviewers update their reviews - perhaps just by appending a diff of the before and after text-rendered review to emails?

kohler commented 1 year ago

HotCRP already stores this information & has for years. Unfortunately, there are some conceptual roadblocks in showing it to users—especially to authors, who should not see most diffs (but should see some)—that have kept me from making it visible. Contributions welcome.

PeterSewell commented 1 year ago

On Sat, 9 Sept 2023 at 13:50, Eddie Kohler @.***> wrote:

HotCRP already stores this information & has for years. Unfortunately, there are some conceptual roadblocks in showing it to users—especially to authors, who should not see most diffs (but should see some)—that have kept me from making it visible. Contributions welcome.

I was primarily thinking of the use for reviewers (and admins, assistant chairs, etc.), for whom I guess one could show all diffs, at least whenever a notification mail would have been sent?

For authors, perhaps the right thing would be diffs while reviews are visible to them, and when they become visible since the last time they were (e.g. to pick up changes between author response and final reviews)? As an author, I typically dump as .txt and run diff manually for the final reviews.

Peter

— Reply to this email directly, view it on GitHub https://github.com/kohler/hotcrp/issues/320#issuecomment-1712504050, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFMZZW6XH436C4K5YAA7ELXZRQXTANCNFSM6AAAAAA4RIZXHM . You are receiving this because you authored the thread.Message ID: @.***>

kohler commented 2 weeks ago

The API endpoint api/PAPER/reviewhistory?r=REVIEWID exposes review versions to review authors & paper managers. Probably most useful is api/PAPER/reviewhistory?r=REVIEWID&expand=1, which expands the diff patch format to full texts. This is not yet visible via the UI but it is there.