duplicated emails to @named users

kohler / hotcrp

HotCRP conference review software

http://read.seas.harvard.edu/~kohler/hotcrp

Other

328 stars 111 forks source link

duplicated emails to @named users #325

Closed JuliaLawall closed 3 months ago

JuliaLawall commented 11 months ago

I had the impression that when a person was named in a discussion message, then they would get one copy of the message by email with a subject line containing Mentioned rather than Comment. But now (ASPLOS'24) I am getting both, and if my name appears multiple times in the message I get one email for each occurrence. This leads to lot of duplicated messages.

kohler commented 3 months ago

Hi @JuliaLawall, I think that you must have been getting different messages for different versions of your name—like “@Julia Lawall” vs “@Julia” or something. In 3abb03c45c I reimplemented the mention logic to avoid double-sending. But that was before 10/30 when you created this issue. Are you still seeing duplicate messages for mentions?

kohler commented 3 months ago

Never mind, I think I found the bug :( Thanks for reporting it.