search

kohler / hotcrp

HotCRP conference review software
http://read.seas.harvard.edu/~kohler/hotcrp
Other
321 stars 109 forks source link

Reviews and comments in plain text | Regex Error #339

Closed tschorlemmer closed 3 months ago

tschorlemmer commented 3 months ago

When clicking on "Reviews and comments in plain text", the following error message is generated:

Warning: preg_match(): Compilation failed: regular expression is too large at offset 83 in /srv/www/api/lib/base.php on line 271
Warning: Cannot modify header information - headers already sent by (output started at /srv/www/api/lib/base.php:271) in /srv/www/api/lib/csv.php on line 1088
Warning: Cannot modify header information - headers already sent by (output started at /srv/www/api/lib/base.php:271) in /srv/www/api/lib/csv.php on line 1090
Warning: Cannot modify header information - headers already sent by (output started at /srv/www/api/lib/base.php:271) in /srv/www/api/lib/filer.php on line 216
Warning: Cannot modify header information - headers already sent by (output started at /srv/www/api/lib/base.php:271) in /srv/www/api/lib/filer.php on line 217
Warning: Cannot modify header information - headers already sent by (output started at /srv/www/api/lib/base.php:271) in /srv/www/api/lib/filer.php on line 236

Text of the reviews and comments still appear, but have incorrect formatting (i.e., missing newlines).

This particular submission has a particularly long rebuttal (a comment that is about 6k words) that may be causing the issue. I believe the version of hotcrp causing this is v3.0b3. This issue may have already been fixed in subsequent commits.

kohler commented 3 months ago

I think this issue has been fixed in later versions. It is about time I bite the bullet and release 3.0

kohler commented 3 months ago

I have released 3.0.0. If you see the problem in current git, please reopen this issue.