kohler / hotcrp

HotCRP conference review software
http://read.seas.harvard.edu/~kohler/hotcrp
Other
321 stars 109 forks source link

Conflicted chair can see reviewers names in comments without override conflict #348

Closed vahldiek closed 1 day ago

vahldiek commented 2 days ago

Hello,

when a chair has a conflict on a paper, reviewer names are not visible: image

But they become visible in comments: image

Is this the expected behavior? Non chair accounts do not see the name (no brackets and name).

I tried looking at the comment/contact code, but couldn't quickly find the place where the logic of pseudonymizing resides. Feel free to point me to it, then I can try to create a path.

Thanks, Anjo

There seems to be a more general difference: image can be deanonymized by clicking: image

But then I also find comment 5: image

p.s.: This is for https://sec24winterae.usenix.hotcrp.com/

kohler commented 1 day ago

Thanks for this report! The issue should be fixed.