kohler / hotcrp

HotCRP conference review software
http://read.seas.harvard.edu/~kohler/hotcrp
Other
327 stars 109 forks source link

Potentially confusing UI combination wrt accept-class papers for recipient selection in mail #355

Open VictorLeP opened 1 month ago

VictorLeP commented 1 month ago

When selecting the recipients of a mail among accept-class papers while also using the "Choose papers" function, I found a potentially confusing combination of options in the UI.

In case I choose:

it seems that non-accept-class papers also make it to the resulting list of papers for which the email should be sent. (In the HotCRP instance where I'm looking, the non-accept-class paper has no decision. I don't know if the behavior would be different for an explicitly rejected paper.)

I'm not sure how this actually pans out in practice (I'm not going to try 😉), i.e., whether the email will end up being sent to the non-accepted paper. In any case, the UI seems confusing in this regard, and emails may be unintentionally sent to non-accept-class papers despite the first selection in the "To:" field.

kohler commented 3 weeks ago

The filter of accept-class is applied after the paper selection phase. So if you had “prepare mail”, you would've seen just the accept-class papers.

kohler commented 2 weeks ago

Gonna reopen this because the UI is a little weird