search

kohler / peteramati

Collect and grade programming problem sets with git
GNU General Public License v2.0
10 stars 4 forks source link

Github OAuth token is not necessarily ctype_alnum #32

Closed ms705 closed 2 years ago

ms705 commented 3 years ago

Ran into this today.

  1. Reauthorized PA with Github, got new OAuth token.
  2. New token was "gho_FZRAY8PB...".
  3. Students ran into this error.

I hotfixed this by removing the ctype_alnum check, which presumably is upset about the underscore in the token. Not sure what the "proper" fix is, though.

ms705 commented 3 years ago

Also affects gitfetch here https://github.com/kohler/peteramati/blob/master/src/github_repositorysite.php#L290.

ms705 commented 2 years ago

Ran into this again today. No longer relevant, was fixed in 03f9f689340efeb008961b2a5d5998e910c7bcc0, so upgrade to latest main fixes it.