kohlhaas / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

Incorrect generated (JSNI) code with non-public generics #136

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. a generics/parameterized class that has to be injected
2. the class has a non-public constructor
3. compile the app

What is the expected output? What do you see instead?
GIN generates a JSNI method to invoke the non-public constructor, but 
incorrectly generates 
"com.example.Foo<com.example.Bar>::new(Lcom/example/Baz;)(_0)" instead of 
"com.example.Foo::new(Lcom/example/Baz;)(_0)"

What version of the product are you using? On what operating system?
r163 on Windows XP

Please provide any additional information below.
See https://groups.google.com/d/msg/google-gin/nX9-2OK6VYE/Mw91zPTzpTIJ

Original issue reported on code.google.com by t.broyer on 4 Feb 2011 at 11:48

GoogleCodeExporter commented 9 years ago
Should be a straight-forward fix, will do this over the weekend.

Original comment by aragos on 5 Feb 2011 at 3:35

GoogleCodeExporter commented 9 years ago
I have verified the fix proposed by Thomas in the group. I'll try to put 
together a unit test and send the patch.

Original comment by philippe.beaudoin on 5 Feb 2011 at 7:06

GoogleCodeExporter commented 9 years ago
See http://codereview.appspot.com/4131046/

Original comment by philippe.beaudoin on 5 Feb 2011 at 8:05

GoogleCodeExporter commented 9 years ago
Updated patch at http://codereview.appspot.com/4023070/

Original comment by aragos on 5 Feb 2011 at 11:24

GoogleCodeExporter commented 9 years ago
Fixed in r165.

Original comment by aragos on 6 Feb 2011 at 1:12