search

kohlhaas / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

Create new example app #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The current example application is rather complex and doesn't cover some of
the new features. This new sample app should cover the basics of a Gin app
and help people get a good start.

Please review at: http://codereview.appspot.com/116052

Original issue reported on code.google.com by aragos on 1 Dec 2009 at 1:41

GoogleCodeExporter commented 9 years ago

Original comment by aragos on 1 Dec 2009 at 1:42

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
1) patching build.xml in trunk fails.
Attempt to see diff in Rietveld:
http://codereview.appspot.com/116052/diff/1/15
gives: error: old chunk mismatch

diff for build.xml is made against previous version, but there is no
samples/simple/build.xml committed in trunk. The patch is really made against
HigherLower's build.xml.

2) There is no build.properties in the project, but build.xml patch references 
them.

Original comment by A.A.Vasi...@gmail.com on 2 Dec 2009 at 9:08

GoogleCodeExporter commented 9 years ago 
App repackaged for GWT-2.0.0-rc2

Original comment by A.A.Vasi...@gmail.com on 2 Dec 2009 at 9:57

Attachments:

GoogleCodeExporter commented 9 years ago 
Submitted in r124. Thanks for the review!

Original comment by aragos on 21 Dec 2009 at 4:30