search

kohlschutter / junixsocket

Unix Domain Sockets in Java 7 and newer (AF_UNIX), AF_TIPC, AF_VSOCK, and more
Apache License 2.0
433 stars 114 forks source link

Update/Fix Dependency Documentation Page (2.1.2) #57

Closed mina-asham closed 5 years ago

mina-asham commented 5 years ago

The dependency documentation page: https://kohlschutter.github.io/junixsocket/dependency.html says that to use the library you need to include junixsocket-core as a dependency.

This artifact does NOT contain the required Java classes anymore, they moved to junixsocket-common, I needed junixsocket-common and junixsocket-native-common for it to work.

The documentation needs updating with that. It also feels weird that I have to add two dependencies in my pom file, can the core package work again?

kohlschuetter commented 5 years ago

Thanks for reporting! I've added the missing dependency to junixsocket-common, so all necessary artifacts should now be retrieved when you add "junixsocket-core" as the dependency. Please verify.

mina-asham commented 5 years ago

Thanks for fixing it so quick, I will test it when next version is released to maven.

runekaagaard commented 5 years ago

Thanks for this, its still an issue.

kohlschuetter commented 5 years ago

Please upgrade your dependencies to junixsocket 2.2.0 and try again

runekaagaard commented 5 years ago

Yes, it works now. Thx!!