search

kohnh / pe

0 stars 0 forks source link

Visibility not indicated #12

Open kohnh opened 1 year ago

kohnh commented 1 year ago

The visibility of the methods in the classes are not stated.

image.png

soc-se-bot commented 1 year ago

Team's Response

image.png

DG Cosmetic Issues should be very low as indicated in instruction

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: The visibility is not purely cosmetical as the developers may assume that the methods are all package private which is the default and may be confused down the line when the public methods are called outside of the package. As such it will affect future implementation or maintenance of the code where the developer's guide does not actually help the developer understand how each class works and have to resort to looking at the code to understand which makes it a low severity.