kohya-ss / sd-scripts

Apache License 2.0
5.13k stars 855 forks source link

TYPO in system, DAdaptAdaN instead of DAdaptAdam! #520

Closed RealBeyondMaster closed 1 year ago

RealBeyondMaster commented 1 year ago

Please correct this typo, I can't start training on DAdaptAdam because it says there is no "DAdaptAdan"! It's with "m" and not a "n",

Thank you.

sdbds commented 1 year ago

plz check u version,

https://github.com/kohya-ss/sd-scripts/blob/c924c47f374ac1b6e33e71f82948eb1853e2243f/library/train_util.py#LL2602C26-L2602C26

the lastest verion use no dadaptaion for all error

T0b1maru commented 1 year ago

I second. latest version has --optimizer_type="DAdaptAdan" instead of --optimizer_type="DAdaptAdam". It's in library/train_util.py etz.

Manually changing the "--optimizer_type=" works so. My guess also is it's a typo. edit: or, it's meant to be caught but.. it doesnt run at all selecting it.

sdbds commented 1 year ago

I second. latest version has --optimizer_type="DAdaptAdan" instead of --optimizer_type="DAdaptAdam". It's in library/train_util.py etz.

Manually changing the "--optimizer_type=" works so. My guess also is it's a typo. edit: or, it's meant to be caught but.. it doesnt run at all selecting it.

i got it. the dadapation V2 both have DAdaptAdam and DAdaptAdan but dadapation V1 just have DAdaptAdam

so if you dont update dadapation , you can just use DAdaptation to use DAdaptAdam

or pip install -U DAdaptation to update V2

Hannibal313 commented 1 year ago

Hi, pip install -U DAdaptation didn't do the trick for me, I have update V2 installed and still get error when using dadaptadan

sdbds commented 1 year ago

Hi, pip install -U DAdaptation didn't do the trick for me, I have update V2 installed and still get error when using dadaptadan

did you use gui https://github.com/bmaltais/kohya_ss

i just tested with origin script.

sdbds commented 1 year ago

this is my test on lastest version(not gui,just original script): DAdaptAdan image

DAdaptAdam image

DAdaptation image

checkout \venv\Lib\site-packages\dadaptation-x.0.dist-info

x is your dadaptation current version if no x,it is V1 plz update your dadaptation version

sdbds commented 1 year ago

Hi, pip install -U DAdaptation didn't do the trick for me, I have update V2 installed and still get error when using dadaptadan

use venv to update, not python in C:\

.\venv\Scripts\activate pip install -U dadaptation

Hannibal313 commented 1 year ago

Thank you very much, it works now

RealBeyondMaster commented 1 year ago

Hi

Thanks for the answers. Still doesn't work for. Updated the venv, did pip install -U DAdaptation Installed V2.

But now when I want to start the gui.bat, it says:

Validating that requirements are satisfied. Error: The following packages have the wrong version:

Run ←[33mupgrade.ps1←[0m or ←[33mpip install -U -r requirements.txt←[0m to resolve the missing requirements listed above...

It doesn't want to start with V2.0. What to do? I use the kohya WEBUI.

Hannibal313 commented 1 year ago

Hi

Thanks for the answers. Still doesn't work for. Updated the venv, did pip install -U DAdaptation Installed V2.

But now when I want to start the gui.bat, it says:

Validating that requirements are satisfied. Error: The following packages have the wrong version:

  • dadaptation==1.5 (expected version dadaptation==1.5, found version 2.0)

Run ←[33mupgrade.ps1←[0m or ←[33mpip install -U -r requirements.txt←[0m to resolve the missing requirements listed above...

It doesn't want to start with V2.0. What to do? I use the kohya WEBUI.

Hi, i just changed dadaptation==2.0 in the requirements.txt and it worked

RealBeyondMaster commented 1 year ago

Ok changed it manually, thank you.

Only thing missing in WEBUI is now the drop down option for DAdaptAdam. There is only DAdaptAdan right now.

Do I need to change this manually too or will there be an update?

sdbds commented 1 year ago

Ok changed it manually, thank you.

Only thing missing in WEBUI is now the drop down option for DAdaptAdam. There is only DAdaptAdan right now.

Do I need to change this manually too or will there be an update?

i think you should open an issue on kohya_WEBUI there. it seems they use old requirements for DAdaptation 1.5 for that version,just use DAdaptation....

RealBeyondMaster commented 1 year ago

Ok will do, thank you all :-)