search

koibots8230 / RumbleBot2024

MIT License
0 stars 0 forks source link

Dependency injection of isReal #2

Open eskiles opened 1 month ago

eskiles commented 1 month ago

@ConradSkelly

he isReal flag is passed into the constructor. However, the checks to see if the robot is real in the constructor and periodic are calling Robot.isReal(). Change these references from the Robot to the this.isReal flag. This allows you to remove the import of frc.robot.Robot.

https://github.com/koibots8230/RumbleBot2024/blob/eef158144149c2a53edf250ccf615ac48a637772/RumbleBot2024/src/main/java/frc/robot/subsystems/Shooter.java#L66

eskiles commented 1 month ago

I see that the private final changes were made in the dev branch. I'm not seeing any changes to the use of isReal. Please use the gitflow branching strategy. https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow Feature development of the shooter should be on the shooter branch. When it is ready, the code is merged to Dev and the feature branch goes away.

This avoids having bad merges where code just disappears. Been there done that, it is horrible.