koibots8230 / RumbleBot2024

MIT License

0 stars 0 forks source link

Create motor factory #3

Closed tobyMickelson closed 1 month ago

tobyMickelson commented 2 months ago

Pull request for Motor Factory

Included Features:

Continuity between code for real world and simulation

Checklist:

[ ] The code builds
[ ] The code has been self or peer-reveiwed
[ ] The code has been tested on the robot & works as intended

eskiles commented 1 month ago

After reading up on WPI simulation, I have found that the difference between real robot and simulation need to be clearly articulated and managed in code. I do not recommend adding this abstraction to encapsulate real and sim motors into a common object.

This is an interesting exercise for learning about design patterns. I recommend re-visiting this concept after the robot code is in a state where you all can field a robot.