koibots8230 / RumbleBot2024

MIT License
0 stars 0 forks source link

Descriptive function names #8

Open eskiles opened 1 month ago

eskiles commented 1 month ago

CheckVelocity doesn't describe what information the function is returning. Use more descriptive names such as isVelocityInRange.

When naming, think about using this in the form of a sentence/conversation: Bob: Check velocity? Anna: True

compared with Bob: is velocity in range? Anna: True

https://github.com/koibots8230/RumbleBot2024/blob/62df01fcafb80018675651ec7a72f0eea305d9dc/RumbleBot2024/src/main/java/frc/robot/subsystems/Shooter.java#L156