search

koichik / node-tunnel

Node HTTP/HTTPS Agents for tunneling proxies
MIT License
537 stars 78 forks source link

onCloseOrRemove needs to provide argument to removeSocket #3

Closed frooble closed 12 years ago

frooble commented 12 years ago

In TunnelingAgent.prototype.addRequest a function is created

  function onCloseOrRemove(err) {
      self.removeSocket();
      socket.removeListener('free', onFree);
      socket.removeListener('close', onCloseOrRemove);
      socket.removeListener('agentRemove', onCloseOrRemove);
    }

I believe the socket variable from closure needs to be provided as an argument

  function onCloseOrRemove(err) {
      //Provide argument to removeSocket
      self.removeSocket(socket);
      socket.removeListener('free', onFree);
      socket.removeListener('close', onCloseOrRemove);
      socket.removeListener('agentRemove', onCloseOrRemove);
    }
koichik commented 12 years ago

@frooble - Thanks, fixed in da4c509.