koide3 / glim

GLIM: versatile and extensible range-based 3D localization and mapping framework
MIT License
522 stars 66 forks source link

Ready pointcloud with intensity #44

Open VanavaraDigital opened 3 months ago

VanavaraDigital commented 3 months ago

Hello, thank you for your great work. I have one trouble: Exported Pointcloud has no intensity value of points. I learned source code and see, that frames points have intensity values, but next step, when you produce submaps from frames, submaps points have no intensity value. Does it possible to add intensity values to points in exported pointcloud ?

Thanks

koide3 commented 3 months ago

The intensity information is lost in the frame merge in sub mapping. If you want intensity data, you need to modify the following part to retain the original intensity information.

https://github.com/koide3/glim/blob/3d65b3b72a730b6b41fc667ed639bae5c29ca78a/src/glim/mapping/sub_mapping.cpp#L461

F-lalala commented 2 months ago

The intensity information is lost in the frame merge in sub mapping. If you want intensity data, you need to modify the following part to retain the original intensity information.

https://github.com/koide3/glim/blob/3d65b3b72a730b6b41fc667ed639bae5c29ca78a/src/glim/mapping/sub_mapping.cpp#L461

Hello,I need to modify the function gtsam_points::merge_frames_auto to add intensity information,but I can't locate where the function was implemented, maybe I should rewrite it by myself? thank you for your reply

koide3 commented 2 months ago

merge_frames_* are in gtsam_points. I'm thinking of implementing a merge function with intensity support, but it has a low priority for now.

F-lalala commented 2 months ago

merge_frames_* are in gtsam_points. I'm thinking of implementing a merge function with intensity support, but it has a low priority for now.

Thanks,I found the declaration of mergeframes* in the file point_cloud_cpu.hpp,but it seems there is no corresponding function implemention in the file point_cloud_cpu.cpp.?