search

koide3 / glim_ext

18 stars 6 forks source link

Is gnss_global compatible with ROS2? #10

Closed changh95 closed 1 month ago

changh95 commented 1 month ago

Hi again,

According to the online documentation, gnss_global is only compatible with ROS2 (https://koide3.github.io/glim/extensions.html).

But then, on the other hand, in the CMakeLists.txt, it says gnss_global does not support ROS2 (https://github.com/koide3/glim_ext/blob/e6d135c0f3d3ddaebc7c31f9f7f19be2e041f37c/CMakeLists.txt#L14).

But then again, in the CMakeLists.txt for gnss_global, it seems like ROS1 and ROS2 builds are both possible.

I'm not sure which one to believe :sweat_smile:

koide3 commented 1 month ago

Correctly, it now supports only ROS2😅 I migrated from ROS1 to ROS2 while developing this package, and the wrong documentation was left. I'll fix the documentation later.

koide3 commented 1 month ago

Closing as the doc is fixed with https://github.com/koide3/glim_ext/pull/12