search

koide3 / glim_ext

23 stars 9 forks source link

global config driver does not seem to load all the existing configs #11

Open changh95 opened 3 months ago

changh95 commented 3 months ago

According to the config_global_ext.json, it will only load sensors_ext, scan_context, dbow, orb_slam, and flat_earther.

{ / GlobalExt Configuration / "global_ext": { "config_path": "", "data_path": "../data", "config_sensors_ext": "config_sensors_ext.json", "config_scan_context": "config_scan_context.json", "config_dbow": "config_dbow.json", "config_orb_slam": "config_orb_slam.json", "config_flat_earther": "config_flat_earther.json" } }

But then in the same config folder, there are configs for gnss_global and velocity_suppressor.

Considering the config structure in GLIM, I think the config_global_ext.json should read other config files too.

koide3 commented 3 months ago

Yeah, configs for those extensions should be added to config_global_ext.json. I'll add them soon.

Currently, this extension package is left cluttered because my bandwidth has been occupied with maintaining the GLIM main package and some other works. But I want to rework this package (at least frequently used modules) once I get time.

koide3 commented 3 months ago

I fixed the config paths and added an explanation about the config path addressing: https://github.com/koide3/glim_ext/pull/13.