search

koide3 / hdl_graph_slam

3D LIDAR-based Graph SLAM
BSD 2-Clause "Simplified" License
1.98k stars 726 forks source link

Use rospy and setup.py to manage shebangs for Python 2 and Python 3 #151

Closed robustify closed 3 years ago

robustify commented 3 years ago

Thanks for providing the community with an excellent algorithm! I noticed you just merged updates to compile in ROS Noetic and updated the Python code to be compatible with Python 2 and 3.

This PR uses rospy to manage the shebangs at the top of each Python node file to support both Python 2 and Python 3 interpreters automatically. These changes were made according to these instructions:

http://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs

koide3 commented 3 years ago

Nice! Thanks a lot for your contribution :+1: