search

koide3 / hdl_graph_slam

3D LIDAR-based Graph SLAM
BSD 2-Clause "Simplified" License
1.98k stars 726 forks source link

Successfully compile to pcl-1.11.1, pcl-ros-1.7.2 and g20-20201223_git #191

Closed AchmadFathoni closed 3 years ago

AchmadFathoni commented 3 years ago

Well, of course the CI will not successfully build this PR because the old package they have. I build this on bleeding edge Arch. I hope this PR will be useful as future reference when those new version packages is released in noetic.

koide3 commented 3 years ago

Thanks! Can we avoid the shared_ptr errors by using pcl::shared_ptr?

AchmadFathoni commented 3 years ago

Changed to pcl::shared_ptr

AchmadFathoni commented 3 years ago

I think this PR does to much think so I separate the transition of shared_ptr to https://github.com/koide3/hdl_graph_slam/pull/192

koide3 commented 3 years ago

Thanks for your contribution. I merge it :+1: