koide3 / hdl_graph_slam

3D LIDAR-based Graph SLAM
BSD 2-Clause "Simplified" License
1.94k stars 723 forks source link

Change boost::shared_ptr to pcl::shared_ptr #192

Closed AchmadFathoni closed 3 years ago

koide3 commented 3 years ago

It seems PCL on melodic doesn't define pcl::shared_ptr and causes some build errors. Maybe a workaround is to use Ptr of each class (e.g., pcl::VoxelGrid<PointT>::Ptr)? At this moment, I'd like to leave this PR (I think this PR would be helpful for people using a newer PCL anyways).

koide3 commented 3 years ago

Based on this PR, I replaced boost::shared_ptr with Ptr. I created a new PR https://github.com/koide3/hdl_graph_slam/pull/206, and thus closing this PR. Thanks again for your contribution.