Add `msf_updates` as run dependency

koide3 / hdl_graph_slam

3D LIDAR-based Graph SLAM

BSD 2-Clause "Simplified" License

1.94k stars 723 forks source link

Add `msf_updates` as run dependency #227

Closed Timple closed 2 years ago

Timple commented 2 years ago

Would prevent issues #226 #138 and #142

Timple commented 2 years ago

Actually a lot of dependencies where configured incorrectly or missing.

I took the liberty of fixing them all.

koide3 commented 2 years ago

Thanks a lot for your PR. I'm going to merge this, but I would like to make msf_updates optional, because many users do not use the IMU feature, and I don't want to force them to install it. Is there any good way to make it optional?

Timple commented 2 years ago

Well, nobody is forcing them to install it. Not installing msf_updates will not give any errors or compilation issues. Until they want to use the imu launchfile. But then they do need it.

So I think it's alright like this.

koide3 commented 2 years ago

Thant's perfect. Thanks again for your contribution :+1: