search

koide3 / small_gicp

Efficient and parallel algorithms for point cloud registration [C++, Python]
MIT License
364 stars 46 forks source link

fix: add template keyword #25

Closed wep21 closed 4 months ago

wep21 commented 4 months ago

This PR fixes the error below when building on m2 mac.

/Users/daisuke/workspace/rolling/src/small_gicp/include/small_gicp/ann/incremental_voxelmap.hpp:56:68: error: missing 'template' keyword prior to dependent template name 'head'
      const Eigen::Vector3i coord = fast_floor(pt * inv_leaf_size).head<3>();
wep21 commented 4 months ago

@koide3 I appreciate it if you could review this PR when you have time.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.77%. Comparing base (9886474) to head (ab95c3e). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #25 +/- ## ======================================= Coverage 91.77% 91.77% ======================================= Files 35 35 Lines 1179 1179 Branches 182 182 ======================================= Hits 1082 1082 Misses 97 97 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

koide3 commented 4 months ago

Thank you for your PR. Merge it now.