koide3 / small_gicp

Efficient and parallel algorithms for point cloud registration [C++, Python]
MIT License
318 stars 40 forks source link

Remove unnecessary include #36

Closed nkhedekar closed 3 months ago

nkhedekar commented 3 months ago

The impl hpp file is already included in the .hpp file and this is without include guards causing a re-declaration error https://github.com/PointCloudLibrary/pcl/blob/af3ce2530b7ae8ed083a3515168626c587a5bbcd/registration/include/pcl/registration/registration.h#

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.77%. Comparing base (0cfdfad) to head (d72906f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #36 +/- ## ======================================= Coverage 91.77% 91.77% ======================================= Files 35 35 Lines 1179 1179 Branches 182 182 ======================================= Hits 1082 1082 Misses 97 97 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

koide3 commented 3 months ago

Thanks!