koide3 / small_gicp

Efficient and parallel algorithms for point cloud registration [C++, Python]
MIT License
318 stars 40 forks source link

Replace nanoflann #42

Closed koide3 closed 2 months ago

koide3 commented 2 months ago

Replace nanoflann with new KdTree implementation for the following reasons:

EDIT: Task-based OpenMP parallelism causes memory issues with Eigen matrices on MSVC. To avoid it, disable parallel kdtree construction on MSVC.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.38562% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.50%. Comparing base (86c2e40) to head (fd418bb). Report is 2 commits behind head on master.

Files Patch % Lines
include/small_gicp/ann/knn_result.hpp 83.33% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #42 +/- ## ========================================== - Coverage 91.77% 88.50% -3.28% ========================================== Files 35 36 +1 Lines 1179 774 -405 Branches 182 70 -112 ========================================== - Hits 1082 685 -397 + Misses 97 89 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.