Closed valgur closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.70%. Comparing base (
3f61cb0
) to head (db669ef
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks a lot. I merge it now.
On an unrelated note - is there a reason why the automatically downloaded Eigen is v3.3.9 instead of v3.4.0?
I picked a random stable version I downloaded in the past for no reason, but I now think we should use the latest one. I'll update CMakeLists soon.
The upper-case
EIGEN3_FOUND
variable is available on v3.3.x, but has been removed in newer Eigen versions.Since Eigen is always packaged with an
Eigen3Config.cmake
and CMake sets<PackageName>_FOUND
automatically forCONFIG
-type packages,Eigen3_FOUND
should be used instead. From CMake docs:On an unrelated note - is there a reason why the automatically downloaded Eigen is v3.3.9 instead of v3.4.0?