search

koide3 / small_gicp

Efficient and parallel algorithms for point cloud registration [C++, Python]
MIT License
393 stars 51 forks source link

disable task-based parallel on windows #50

Closed koide3 closed 5 months ago

koide3 commented 5 months ago

/openmp:llvm brings the dependency on libomp140.dll, which is not included in MSVC redistables and thus forces the user to install the whole Visual Studio. Because it seems /openmp doesn't cause such a dependency, I choose to remove /openmp:llvm and task-based parallel. This change would result in a speed degradation for downsampling. But the majority of the package is still parallelized, and the influence to the total processing time should be minor.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.70%. Comparing base (eec9c4a) to head (084d389).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #50 +/- ## ======================================= Coverage 93.70% 93.70% ======================================= Files 36 36 Lines 779 779 Branches 74 74 ======================================= Hits 730 730 Misses 49 49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.