koinos / koinos-chain

The chain microservice is responsible for the application of blocks, running of smart contracts, and applying transactions.
Other
15 stars 3 forks source link

PoW verify_block_signature causes side effects #408

Closed mvandeberg closed 2 years ago

mvandeberg commented 3 years ago

The PoW verify_block_signature override causes side effects both in the pow metadata object and block producer balances.

The call to verify_block_signature implies that it should not have side effects because of the check_block_signtature option to apply_block.

There are two solutions to the problem:

sgerbino commented 2 years ago

For now, we will remove verify_block_signature, verify_passive_data, and verify_transaction_signature flags from submit_block_request and all the related places within koinos-chain.

As well as rename the system call to indicate it does more than verification: verify_block_signature -> process_block_signature