search

koinos / koinos-io-website

Repo for koinos.io website
MIT License
2 stars 6 forks source link

Background that matches the slate of the documentation site #50

Closed sgerbino closed 5 months ago

sgerbino commented 5 months ago

Brief description

This changes the background color of the site to match that of the documentation site, adjusts the hero image and mobile image accordingly (I think). Putting up a PR to have a look.

netlify[bot] commented 5 months ago

Deploy Preview for koinos-io ready!

Name Link
Latest commit fab2f6cfa0d4bd55e69ed0aa12270e68ab1af592
Latest deploy log https://app.netlify.com/sites/koinos-io/deploys/6660bfecd50d250008c206af
Deploy Preview https://deploy-preview-50--koinos-io.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sgerbino commented 5 months ago

Probably could make the lighter boxes match the lighter slate color of the documentation site...

mvandeberg commented 5 months ago

This has the background of the site match the header of docs site. If the purpose of this PR is to make those sites feel more continuous, I don't think this change achieves it because the background colors are still changing. Granted, I am not a designer, but it isn't working for me.

sgerbino commented 5 months ago

This has the background of the site match the header of docs site. If the purpose of this PR is to make those sites feel more continuous, I don't think this change achieves it because the background colors are still changing. Granted, I am not a designer, but it isn't working for me.

It's at least using the same colors. I think the site looks better on the darker background and using the lighter one as a highlight would probably make them feel more connected.

They don't have to look like the same site, but at least related...

sgerbino commented 5 months ago

WIP: Trying to have a clever way to use #1e2129 as box highlight color in dark mode

jredbeard commented 5 months ago

WIP: Trying to have a clever way to use #1e2129 as box highlight color in dark mode

oh ok - which boxes?

sgerbino commented 5 months ago

WIP: Trying to have a clever way to use #1e2129 as box highlight color in dark mode

oh ok - which boxes?

All these secondary colors is what I was thinking image image image

sgerbino commented 5 months ago

For some reason the Whitepaper page has a completely different background, also the menu dropdown.

There is some janky css where I guess this color gets repeated in many places

image

sgerbino commented 5 months ago

Karlos made a new favicon, I think it looks MUCH better

jredbeard commented 5 months ago

Karlos made a new favicon, I think it looks MUCH better

Awesome! if you want, you can just use a PNG now. Even for a die hard compatibility snob like me, if someone is using a browser that is 15 years old and can't support it, they can just not see the favicon. It's totally fine.

jredbeard commented 5 months ago

For some reason the Whitepaper page has a completely different background, also the menu dropdown.

Thie whitepaper page looks to have the same new slate background to me.... at least locally in a build it does anyway. I checked the chrome inspector and it shows the correct background color on the body after navigating to the whitepaper.

jredbeard commented 5 months ago

For some reason the Whitepaper page has a completely different background, also the menu dropdown.

Thie whitepaper page looks to have the same new slate background to me.... at least locally in a build it does anyway. I checked the chrome inspector and it shows the correct background color on the body after navigating to the whitepaper.

@sgerbino I take this comment back lol. You have a better eye than me. I think I see the problem

jredbeard commented 5 months ago

@sgerbino I take this comment back lol. You have a better eye than me. I think I see the problem fixed: https://github.com/koinos/koinos-io-website/pull/53

jredbeard commented 5 months ago

All these secondary colors is what I was thinking

ok fixed here: https://github.com/koinos/koinos-io-website/pull/54