search

koinos / koinos-p2p

The p2p microservice orchestrates the distribution of blocks and transactions between peers.
MIT License
6 stars 4 forks source link

Block Failures Loop #107

Closed mvandeberg closed 3 years ago

mvandeberg commented 3 years ago

When a block fails to apply, the sync code attempts to re-apply it continually.

mvandeberg commented 3 years ago

This seems to be somewhat fixed by #115

theoreticalbts commented 3 years ago

What still needs to be done? If it's fixed, let's close this ticket. If it's not fixed, let's add a specific description of what still needs to be fixed.

theoreticalbts commented 3 years ago

After some discussion, we've decided the long term solution is proper naughty point handling (see #5) and a potential peer block backoff list (don't request an errored block from a peer for a certain amount of time after an errored block).

For those reasons, we'll consider this issue to be closed by #115.