koinos / koinos-p2p

The p2p microservice orchestrates the distribution of blocks and transactions between peers.
MIT License
6 stars 4 forks source link

[BUG]: Error score easily gamed #220

Closed mvandeberg closed 1 year ago

mvandeberg commented 1 year ago

Is there an existing issue for this?

Current behavior

Peer error scores are tracked by Peer ID. Peer IDs are randomly generated when a p2p node starts. This means, I can misbehave and then restart my p2p node. My previous peer ID will be the ban hammer, but I can reconnect and instantly have an error score of 0.

Expected behavior

When I misbehave, the error score should track me more closely. IP address would probably be a better choice for tracking error score as it is harder to change. This is also the identifier that most other services use to band users and it has largely proven effective.

Steps to reproduce

No response

Environment

- OS: All

Anything else?

No response