koinos / koinos-proto

Official home of the Koinos Protobuf schema. Koinos data types are defined here and generated in a variety of supported languages.
MIT License
3 stars 7 forks source link

[FEATURE]: Add abi_type field to upload_contract_operation #164

Closed theoreticalbts closed 1 year ago

theoreticalbts commented 1 year ago

Is there an existing issue for this?

New feature

The ABI field of upload_contract is currently JSON.

In future we might want to support other formats (binary / zipped / hash of ABI data stored off-chain in Git / IPFS / community site) so we should add a new string field telling clients how they should parse the data in the abi field (suggested field name: abi_type).

Anything else?

One alternative is to change abi to be oneof instead, which may be slightly more wire efficient, but there are several good reasons not to:

koinos-ci commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

koinos-ci commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.