coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 666
- 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
- 11 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.05%) to 99.427%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| tests/cpp/src/json_pack_test.cpp | 9 | 10 | 90.0% | ||
| <!-- | Total: | 9 | 10 | 90.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| build/generated/cpp/include/koinos/pack/rt/binary.hpp | 2 | 99.13% | ||
| build/generated/golang/src/github.com/koinos/koinos-types-golang/basetypes.go | 2 | 99.75% | ||
| build/generated/cpp/include/koinos/pack/rt/json.hpp | 7 | 94.36% | ||
| <!-- | Total: | 11 | --> |
| Totals | |
|---|---|
| Change from base Build 661: | -0.05% |
| Covered Lines: | 7978 |
| Relevant Lines: | 8024 |
theoreticalbts
Closes #153.
I put the new multihash implementation in separate header files because we've created a dependency between
binary.hppandjson.hpp. JSON really only needs the binary serializations needed to serialize multihashes, but separating the existing different types into their own headers is a huge refactoring way outside this ticket. So I compromised by putting the new multihash code in its own header. We may want to look at this later.