Implement multibase for C++

koinos / koinos-types

The Rosetta Stone of the Koinos ecosystem. Allows for the interpretation of Koinos data structures in a multitude of languages. Useful in the development of microservices, clients, and smart contracts.

MIT License

12 stars 3 forks source link

Implement multibase for C++ #171

Closed theoreticalbts closed 3 years ago

theoreticalbts commented 3 years ago

Closes #168. Resolves #169.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 676

0 of 0 changed or added relevant lines in 0 files are covered.
11 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-1.6%) to 97.867%

Files with Coverage Reduction	New Missed Lines	%
build/generated/cpp/include/koinos/pack/rt/exceptions.hpp	1	77.78%
build/generated/cpp/include/koinos/pack/rt/json.hpp	5	96.3%
build/generated/cpp/include/koinos/pack/rt/util/base58.hpp	5	92.31%
<!--	Total:	11	-->

Totals
Change from base Build 674:	-1.6%
Covered Lines:	8074
Relevant Lines:	8250

💛 - Coveralls

theoreticalbts commented 3 years ago

The copyright wasn't removed, it was moved lower in the file.

For more clarity about what copyright applies to what code, I'm going to update the branch and put the code from Bitcoin in a separate header file from our code.

theoreticalbts commented 3 years ago

Updated this PR:

Addressed copyright issue
Added tests
Fixed several bugs uncovered by the tests

Also added a Monte Carlo test which you can run forever by:

    ../programs/test_multibase/multibase_mc.py | programs/test_multibase/test_multibase

You can insert a filter, e.g. -head 1000 to do 1000 cases, or pv -l to see a progress bar. The MC test has passed over 5 million cases with no failures.