Review varint binary serialization, test golang against C++

koinos / koinos-types

The Rosetta Stone of the Koinos ecosystem. Allows for the interpretation of Koinos data structures in a multitude of languages. Useful in the development of microservices, clients, and smart contracts.

MIT License

12 stars 3 forks source link

Review varint binary serialization, test golang against C++ #177

Closed theoreticalbts closed 3 years ago

theoreticalbts commented 3 years ago

It seems to_binary() here has a couple issues:

(1) It seems to write in little-endian order, but I believe golang lib uses big-endian order.
(2) Loop at the end pointlessly writes one byte at a time, let's instead do s.write(tmp, len+1)

We must not be testing golang against C++ for binary serialization.

mvandeberg commented 3 years ago

Commit d68d9e88343cb847fde46059b925b42c87fc01d8 might have addressed this issue