[FEATURE]: verify checksum in `CheckIsValidAddress` - Githubissues

koinos / koinos-util-golang

A utility library used by Koinos Golang applications.

MIT License

2 stars 1 forks source link

[FEATURE]: verify checksum in `CheckIsValidAddress` #37

Open joticajulian opened 1 year ago

joticajulian commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

New feature

Verify the checksum in CheckIsValidAddress:

https://github.com/koinos/koinos-util-golang/blob/0c4eb59be62dbf88ca21e187d530533a2016770a/output.go#L75

The address has 25 bytes, consisting of 3 parts:

prefix: 1 byte
data: 20 bytes
checksum: 4 bytes

Verify this:

The prefix must be 0 (for P2PKH addresses)
checksum must be equal to first 4 bytes of sha256(sha256(prefix + data))

Reference: https://medium.com/coinmonks/how-to-generate-a-bitcoin-address-step-by-step-9d7fcbf1ad0b

Anything else?

No response

sgerbino commented 1 year ago

Related to #33.

koinos-ci commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.