search

koji-kojiro / cl-repl

A full-featured repl implementation designed to work with Roswell
GNU General Public License v3.0
153 stars 22 forks source link

fix "y" the default to quit #15

Closed vindarel closed 6 years ago

vindarel commented 6 years ago

Hello,

First of all: CONGRATS, this is really awesome ! There is room for more features (highlight matching parens, proper restarts…), but cl-repl already offers a lot and it fills a need. I really like it :)

In this PR:

Thanks, see you !

koji-kojiro commented 6 years ago

Thanks to contribute! I'm still a beginner on Common Lisp, and this is my first hack in CL. So I really appreciate it.

koji-kojiro commented 6 years ago

I'll check it later and then soon merge.

koji-kojiro commented 6 years ago

The executable does not seem to work as expected. (e.g. tab completion) I always use a symlink from ~/.roswell/local-projects to test my local projects with roswell. (see FAQ of Roswell)

"y" seems to be fine for me. To be honest, I could not understand what the commit tries to solve ... Would you explain the meaning of added ""?

vindarel commented 6 years ago

Nice project for a first one :)

When I want to quit cl-repl, with C-d, I get the confirmation with "[y]/n": typing "y" works, but typing pressing Enter directly (which is supposed to quit, as says "[y]") did not quit, it asked again.

You are right, tab completion does not work in the executable :(

vindarel commented 6 years ago

I removed the commit of the executable from the PR.

koji-kojiro commented 6 years ago

I got it now. I designed the function by referring to ipython's behaviour. But, I prefer this now.

Now I'm writing this comment from mobile, so I'll merge this PR later.

vindarel commented 6 years ago

ok cool :) I'm pretty sure this is ipython's behavior though.

koji-kojiro commented 6 years ago

I was a little confused...

ok cool :) I'm pretty sure this is ipython's behavior though.

You are right al all. And this behaviour is what I truly expected. Thanks.