koji-kojiro / cl-repl

A full-featured repl implementation designed to work with Roswell
GNU General Public License v3.0
153 stars 22 forks source link

%edit command not working #60

Open justjoheinz opened 1 year ago

justjoheinz commented 1 year ago

Invoking %edit with or without filename results in an error:

CL-USER> %edit
CL-REPL will make a temporary file named: /var/folders/vr/t70kp3dd5m14_99ngdw8gdv40000gn/T/cl-repl-editJAIDFZTC.lisp
Openning file: /var/folders/vr/t70kp3dd5m14_99ngdw8gdv40000gn/T/cl-repl-editJAIDFZTC.lisp
Error: The value
                        NIL
                      is not of type
                        (OR STRING PATHNAME SYNONYM-STREAM FILE-STREAM)
                      when binding PATHNAME
[OUT]: NIL
CL-USER> %edit "repl.lisp"
Openning file: repl.lisp
Error: The value
                        NIL
                      is not of type
                        (OR STRING PATHNAME SYNONYM-STREAM FILE-STREAM)
                      when binding PATHNAME

the installation is

cl-repl 0.6.4 on Roswell 22.12.14.113, SBCL 2.3.1

using Mac OS.

justjoheinz commented 1 year ago

Ah, just found that it is not the problem with the file provided, but with the env var EDITOR not being set. Maybe the check could provide a better error message? Please feel free to close the issue, I just leave it open for your attention.