search

koji-kojiro / cl-repl

A full-featured repl implementation designed to work with Roswell
GNU General Public License v3.0
153 stars 22 forks source link

What is the status of this project? #61

Open daninus14 opened 10 months ago

daninus14 commented 10 months ago

Is anyone actually using this?

It says Work In Progress in the readme, but it has not been updated for 4 years. Does that mean it's semi-stable? Are people using this? It's advertised in roswell

vindarel commented 10 months ago

semi-stable?

It works for what it does, indeed.

There's an active fork here: https://github.com/digikar99/cl-repl/releases @digikar99 just added (like, last week) two great features:

He didn't send a PR, IDK if that's the plan. I would vote for him being a co-maintainer of this repository.

digikar99 commented 10 months ago

This repository looked unmaintained, so I did not create a PR. I also just ended up finding out koji-kojiro has been out of github from 2021 :(.

Regardless, people can always cherry-pick the commits or parts of the codebase to integrate into their own.

The GPL license can be an issue though!

daninus14 commented 10 months ago

@vindarel @digikar99 Thanks for the answers. Maybe someone who has his contact info can contact him and get him to add @digikar99 as a maintainer.

@fukamachi do you happen to know how to get in touch with @koji-kojiro ? If not, do you know anyone who does?

fukamachi commented 10 months ago

@daninus14 Unfortunately not. I sent PRs (#53, #54, #55) but got no replies. I'll ask Japanese guys who may know him/her.

daninus14 commented 10 months ago

@fukamachi Thanks for replying and trying to contact him/her.

fukamachi commented 10 months ago

I've asked people who may know, but no one seems to have contacted him/her in person. Sorry.

daninus14 commented 10 months ago

Thanks for trying!

Since this is the state of things, I suggest we join forces and move on.

How about using one of your forks as the official from now on, merge the pull-requests from the other to the selected one to be the official one, and use that from now on in the community, updating the docs to ros install from that repo?

Since @fukamachi already has 3 pull-requests vs 1 for @digikar99 , I think it makes sense to join on that one.

@fukamachi could you add @digikar99 as a maintainer for your fork? @digikar99 can you merge all your commits to that repo?

Worse case scenario, if @koji-kojiro shows up, we can eventually just do a merge to the original repo and add you guys as maintainers.

What do you think?

digikar99 commented 10 months ago

I'm okay issuing PRs to @fukamachi's fork - no need to add me as a maintainer. But if fukamachi could be busy sometimes, I can certainly lend a helping hand with the maintenance!

vindarel commented 10 months ago

What do you guys think of hosting the fork on the organization https://github.com/lisp-maintainers/ ? I created it but that doesn't mean I maintain all projects. Instead, I will give push rights to @digikar99 and @fukamachi (if you agree) and whoever wants to step up as a maintainer.

The goal is to share the work, and avoid this issue of a maintainer not responding in the future.

There are 3 other active lispers who maintain a library there and are part of the org (oh BTW, digikar is already part of it).

I'm okay if you all prefer to use E. Fukamachi's fork.

(I also sent an email to koji-kojiro)

digikar99 commented 10 months ago

I don't see a con of maintaining cl-repl under lisp-maintainers. So, I'm okay with that too - might even prefer that way.

fukamachi commented 10 months ago

I'm no longer using cl-repl, so don't count on me as a maintainer.

digikar99 commented 10 months ago

In that case, I can transfer the ownership of my fork to lisp-maintainers and cherry-pick fukamachi's commits.

digikar99 commented 10 months ago

Done: https://github.com/lisp-maintainers/cl-repl

daninus14 commented 10 months ago

All the best with this!

@vindarel Btw, might be a good idea to update the link here: https://github.com/roswell/roswell/wiki/List-of-Roswell-Installable-Scripts I tried editing the wiki but couldn't find the edit link, and it looks like you have permissions since the last edit was by you in 2021 ;)

vindarel commented 10 months ago

@daninus14 I can't find it either :S

BTW, and consequently, it could be worth not closing this issue ? So people who come to this repository and have a look at the open issues will find the maintained fork.

daninus14 commented 10 months ago

@vindarel it must be they changed the permissions... good idea, I'll reopen the issue.