updates for recent python and matplotlib

koji-kojiro / matplotlib-d

MIT License

10 stars 6 forks source link

updates for recent python and matplotlib #9

Open John-Colvin opened 7 years ago

John-Colvin commented 7 years ago

Changes

Use an environment variable (MATPLOTLIB_D_PYTHON) instead of whatever python happens to be.
python3 doesn't support lowercase from string, so use ascii_lowercase instead (matplotlib functions are all ascii anyway)
recent matplotlib has a function called deprecated, which is a D keyword. By testing for invalid identifiers and appending an _ to them, we avoid this problem and any other similar ones that may come along.

koji-kojiro commented 7 years ago

Hi, @John-Colvin

What's the purpose of using $ MATPLOTLIB_D_PYTHON instead of system's python? I think it's slightly complicated for users to set environment variables before installation.

TritiatedWater commented 7 years ago

Maybe removing brew install python$PYTHON_VER will help?