search

kokarare1212 / librespot-python

Open Source Spotify Client
http://librespot-python.rtfd.io
Apache License 2.0
235 stars 45 forks source link

Bug fixes and Code Refactoring #242

Closed Advik-B closed 1 year ago

Advik-B commented 1 year ago

The base code refactoring is provided by Sourcery https://github.com/Advik-B/librespot-python/pull/1

Hotfix 1: Fix SSL warning/error https://github.com/kokarare1212/librespot-python/commit/17a4f4626b599725df0a4483ff993978e5aa75f5 https://github.com/kokarare1212/librespot-python/commit/784f0ff93f7d2cf8edfdb0a389a2ca2571d249fe

Hotfix 2: Fixing a parsing error https://github.com/jsavargas/zspotify/issues/149#issuecomment-1773865540

kokarare1212 commented 1 year ago

The new method of obtaining expiration dates has already been implemented in this commit. It is also dangerous to disable SSL verification.

Advik-B commented 1 year ago

The new method of obtaining expiration dates has already been implemented in this commit. It is also dangerous to disable SSL verification.

Do you want me to re-enable SSL?

kokarare1212 commented 1 year ago

Perhaps what this PR needs is a reference tag, and Restyled.io has already done that.

Advik-B commented 1 year ago

Perhaps what this PR needs is a reference tag, and Restyled.io has already done that.

Alright, ill re-enable ssl, what else?

kokarare1212 commented 1 year ago

Anyway, this PR is no longer needed as a temporary solution has been implemented.

241

Advik-B commented 1 year ago

Fineee 😞