search

kokarn / tarkov-tools

https://tarkov-tools.com
MIT License
70 stars 44 forks source link

Estimated savings are misleading with barters for items that cannot be bought anywhere #137

Open Iodred opened 2 years ago

Iodred commented 2 years ago

Inspecting items that cannot be bought directly from the Flea and any trader, when they have a barter, the Estimated savings are the same as the InstaProfit value.

Examples are the MMAC rig at Ragman and the REAP-IR scope

This is misleading because technically there's no savings to be made cuz you can't technically buy them anywhere. My proposal is to just show 'N/A' or 0 with a tooltip that says 'This item cannot be bought for money' or something along those lines. And for the Barter profit table for ranking you would then just treat them as a zero.

kokarn commented 2 years ago

That's a good point, will implement something along these lines 👍 Have been thinking a while about how to treat all these things with "no value" etc, and this sounds like a nice solution. Thanks!