kokarn / tarkov-tools

https://tarkov-tools.com
MIT License
70 stars 44 forks source link

In Hideout Profit, in cost, consider barter price #57

Closed Shebuka closed 3 years ago

Shebuka commented 3 years ago

In Hideout Profit include barter when considering the lowest price for components cost.

As example to craft Ripstop cloth you need 3x Scav Vest:

it's 3 X 20 220 ₽ = 60 660 ₽ for Flea market but only 3 X 9 616 ₽ = 28 848 ₽ if bought as barter for Slickers bar

this turns the negative -18 680 ₽ in a 13 132 ₽ profit which is the best profit among Lavatory crafts.

kokarn commented 3 years ago

Thanks for the suggestion! This has been discussed a few times in Discord, and it's for sure a great idea.

Right now I'm mostly missing a good way to display this before I can start implementing it.

Some questions:

Shebuka commented 3 years ago

The easiest way I think is to add a switch like with fuel to switch on or off the barter consideration and add a tooltip with the caveats about barter. That it can be locked behind stock or quest (loyalty level can be filtered as you say by level dropdown that is already in place)

kokarn commented 3 years ago

So in the case of the keycard where there's multiple barters available, which should be used for calculations? The cheapest? The most "probable"? The one with the highest requirements?

In this image, what would you say the expected "price" for the keycard in the UHF RFID Reader craft would be? image

Shebuka commented 3 years ago

On Hideout profit page always the cheapest available. On the item page there can be one or two entries: flea cost/profit and, if barter cost is lower, a barter cost/profit. Or keep one entry and add the barter switch here too.

The barter symbol (the two arrows in circle) can be used to indicate that one (or more) components are from the barter on both pages for the cost column.

TarkovTools
kokarn commented 3 years ago

I like it!

Shebuka commented 3 years ago

Switch and one entry version:

TarkovToolsSwitch
kokarn commented 3 years ago

This actually looks damn nice. I've started working on this with the API changes first

kokarn commented 3 years ago

WIP Screenshot 2021-06-14 at 15 32 39

Shebuka commented 3 years ago

Great job! What is the condition for UHF RFID Reader to not use barter price for TerraGroup Labs access keycard?

kokarn commented 3 years ago

So in the first iteration I only calculated barter prices that are 1-1, so slickers bar etc. Looking at it now, it kinda doesn't make sense to do it that way so will probably do another pass where I add multiple ones.

One thing to note tho is that all of those prices will be misleading when the wipe is in full swing, as labs card for gp coins etc are always sold out