kokarn / tarkov-tools

https://tarkov-tools.com
MIT License
70 stars 44 forks source link

Strange cost and price mismatch (Flea/barter?) #86

Closed Shebuka closed 3 years ago

Shebuka commented 3 years ago

Hello, so I was looking for Hideout Profit and something strange is happening right now with Gas Analyzer: https://tarkov-tools.com/item/gas-analyzer

Screenshot 2021-07-21 at 13 02 22

Currently, it's "sell for" 14 000 ₽ and "buy for" 14 874 ₽

But if you look at barter for "MP9 9x19 30-round magazine" it says cost is 24 729 ₽ (also same cost as a component for Grizzly medical kit, also same cost as CPU Fan 🤔)

More strangely, if you look at crafts of "Printed circuit board" it suggests doing barter with "CPU Fan" for 19 000 ₽... but you can buy it directly from flea for 14 874 ₽!

kokarn commented 3 years ago

It's not quite as strange as it seems. It's very bad UX tho.

Basically, all those three prices are calculated differently.

Buy & sell for uses average from last 24 hours, while barters & crafts don't.

Crafts also looks for barters for a better price, while barters don't look for "chain"-barters, which it should.

I'll work on making this a lot clearer 😓

Shebuka commented 3 years ago

I still think there is something wrong in the calculation or in the internal sort of alternative price results.

p.s. I do understand that for the craft you use sell price to calculate profit and buy price to calculate the cost and that is the only correct way to do it. But the "buy for" price of "Gas analyzer" is cheaper than "buy for" price of "CPU Fan"...

kokarn commented 3 years ago

For barter "MP9 9x19 30-round magazine", where is 24 729 ₽ picked from?

It's from "average from the last 24 h" which is not displayed anywhere else.

Barter calculation thing

That's the same thing I'm afraid, it's displaying one value and calculating another. It's calculating vs the 24 729 value where 19 000 is chaper.

Thanks for digging.

I'll have another look when going over all the crafts & values to make sure there's nothing funky going on but I will also make sure to use the same display value so it's intuitive.

Shebuka commented 3 years ago

It's from "average from the last 24 h" which is not displayed anywhere else.

I get it. My point is, I don't think it is of "Gas analyzer" because it is impossible that it is exactly the same average as for "CPU Fan". I don't know how it happened but it is somehow displaying the barter for "CPU Fan" with the image of "Gas analyzer" and/or without realizing that it's a barter... And by having this mixed up then also craft cost and profit comparison with alternatives are mixed up.

Thanks for digging.

Glad to help 😉 👍

kokarn commented 3 years ago

Working on improvements right now. Here's the current progress. Apart from using "buyFor" or "sellFor" values. do you spot anything else that seems off?

image

kokarn commented 3 years ago

Actually pushed this, so will be live in a few minutes. Please try to find inconsistencies where a available 👍

Shebuka commented 3 years ago

I see, now the prices I think are all right.

But there is no indication when the cost displayed is for the component bartered for something (like the Scav vest for Slickers when crafting Ripstop fabric)

Screenshot 2021-07-23 at 14 40 05 Screenshot 2021-07-23 at 14 40 36
Shebuka commented 3 years ago

This is also strange, "Printed circuit board" craft, the price is calculated correctly, but then it shows in the sum to be from "CPU Fan"

Screenshot 2021-07-23 at 14 45 39

EDIT: From Slickers chocolate bar page:

Screenshot 2021-07-23 at 14 49 51

Seems it is only a visualization problem as all totals are correct

kokarn commented 3 years ago

All of these are now looking fixed when I'm investigating. Also includes #49

Shebuka commented 3 years ago

Hi, me again. Wilston cigarettes must be a 2,3k profit craft using 42nd Signature Blend English Tea barter, why it's using the sellFor cost?

Screenshot 2021-08-24 at 12 10 00
kokarn commented 3 years ago

Yeah, this is an old thing when I initially added so only barters that were 1-1 would be counted as a suggested barter. I've updated that locally and should be fixed with the next push.

Thanks for reminding me!