search

kokernutz / traktor-kontrol-screens

Replacement screens for the Native Instruments Traktor Kontrol D2, S5, and S8
105 stars 40 forks source link

Filter button not working #12

Open epikurus opened 6 years ago

epikurus commented 6 years ago

After last update:

jkudish commented 6 years ago

Same issue here

kokernutz commented 6 years ago

Is this on the S8? I will revert the change for the S8 as I don’t have it right.

gcwioro commented 6 years ago

just downloaded and it worked like a charm on my s5. Best Mod I've ever seen. Many Thanks. BTW: To control the 3, 4 fx units would be a cool feature

epikurus commented 6 years ago

Is this on the S8? I will revert the change for the S8 as I don’t have it right.

Yes, it happens on the S8. I'd be happy to test any changes to make it work.

Great work on the mod BTW :)

kokernutz commented 6 years ago

I reverted the S8 files back to their original state. @epikurus I may ask you to test a new file to see if I get the code right for the S8.

epikurus commented 6 years ago

@kokernutz of course! I'm using the mod on live situations FYI.

Just updated to the latest commit and the Filter button is working again.

jkudish commented 6 years ago

Thanks! Happy to help test on the s8 as well

bascurtiz commented 6 years ago

Awesome update @kokernutz ! But indeed, "Cycle through MixerFX on S5/S8 by pressing SHIFT-FILTER" doesn't work. I assume when holding SHIFT and rotating a FILTER-knob it should select a different Filter setting.

Since I got a S8, I'm willing to help out. Which part/file is responsible for this function? And which values I could try to change?

Also, Midi Controls are Enabled in Traktor Pro 3 in Preferences. But for this, it uses HID right?

MrPatben8 commented 6 years ago

Found a workaround for this problem, here is the issue page for it. https://github.com/kokernutz/traktor-kontrol-screens/issues/14