search

kokernutz / traktor-kontrol-screens

Replacement screens for the Native Instruments Traktor Kontrol D2, S5, and S8
102 stars 40 forks source link

Added MixerFX cycling for Kontrol S8 #15

Closed MrPatben8 closed 4 years ago

MrPatben8 commented 5 years ago

You can do so by pressing SHIFT… + FX arrow buttons on the respective channel.

If you are using 4 FX units then the filter must me ON in order for MixerFX selection, otherwise if the filter is OFF then pressing SHIFT + FX arrow buttons will route the channel to FX units 3 & 4 respectively.

jkudish commented 5 years ago

Hey there,

I tried your patch, and it works to cycle through the mixer FX; however, despite pressing shift + FX arrow, it still assigns FX Unit 2 to the channel, which is not the desired effect. I can workaround this by not having anything on in the FX unit, but it can get confusing.

Feel so close!

jkudish commented 5 years ago

I think this line needs to be changed to && instead of || for it to not engage the FX units when shift is pressed. I just tested it and it works 👍

I can't seem to make a commit on your PR, so will let you do so.

MrPatben8 commented 5 years ago

Alright thanks! I'll take a look at that ASAP

MrPatben8 commented 5 years ago

Alright, fixed the issue by removing || (fxMode.value == FxMode.TwoFxUnits) It should all be working now! The issue with changing || to && is that if the user is using 4 FX units then pressing the FX arrow buttons will do nothing since fxMode.value == FxMode.TwoFxUnits would be false.

Thank you @jkudish for pointing this issue out!

MrPatben8 commented 5 years ago

You guys might like this. So the new Traktor S4 & S2 MK3 have a reverse button. Holding this down will temporarily activate Flux mode and begin to play the track in reverse. I did't see any way of controlling this on my S8 so I decided to add it. Simply press SHIFT + FLUX on the corresponding deck in order to activate Flux Reverse.

jkudish commented 5 years ago

Nice!

MrPatben8 commented 5 years ago

@kokernutz Done, separate pull request is here

RixtarCorp commented 5 years ago

Any news of when the conflicts will be resolved and the mixer effects for S8 will be merged?

Thanks for all the great work!

MrPatben8 commented 5 years ago

Any news of when the conflicts will be resolved and the mixer effects for S8 will be merged?

Thanks for all the great work!

@RixtarCorp I'm not sure why those conflicts are present since those files are unmodified from the original, resolving the conflicts should be as easy as simply keeping the local changes, but that's up to @kokernutz.

RixtarCorp commented 5 years ago

@kokernutz Any chance we could get this merged? It would make me rather happy!

skymakai commented 5 years ago

Seems to also work when applied to the S5 Channel.qml.

Only issue is S5 Screen doesn't show the FX Name; It shows "MFX1", "MFX2", etc, etc.

skymakai commented 4 years ago

Also found on the S5, the mixer effects selection button change state when holding shift, and do not show the proper state of on/off.