search

kokernutz / traktor-kontrol-screens

Replacement screens for the Native Instruments Traktor Kontrol D2, S5, and S8
105 stars 40 forks source link

Camelot Key on S4mk3 #29

Open yuletide opened 5 years ago

yuletide commented 5 years ago

Hey folks, Just got an s4mk3 and was sent here by another fan. I'm very new to QT but managed to get Camelot keys to show, but not while respecting the preference setting -- I'm guessing because of the nested if's. Is there a better way to do this?

text: deckInfo.hasKey ? (prefs.camelotKey ? utils.convertToCamelot(deckInfo.keyString) : deckInfo.keyString) : "No key"

When I take out the preference check it works fine:

https://github.com/yuletide/traktor-kontrol-screens/commit/4371ff3d0f0f98d740f2429af3d21ae7a17c3248

Edit: Thought I fixed it but not quite there. If prefs.camelotKey = false it just shows "No Key" for every track. If true then we get camelot keys https://github.com/yuletide/traktor-kontrol-screens/commit/39c540e60e5fcad259e77684cc275af7bd197d29

kokernutz commented 5 years ago

Heya!

Nice work!

I ordered an S4 MK3 and it's getting delivered on Wednesday. I was going to update my mods so it displays Camelot keys on the new controller. Can you wait until then?

yuletide commented 5 years ago

@kokernutz Of course! I also added in setting key text color based on your utility functions which looks great. Excited to see what else we can do with these little screens.

Unrelated, but have you any experience creating mappings? My next attempt was to somehow change master tempo (there's no knob), but I think we can do that without messing about in qml

kokernutz commented 5 years ago

Yes, I made a keyboard mapping so I could prep tracks quickly.

Doesn't SHIFT-TEMPO FADER do that? I had an S4 MK2 years ago and vaguely remember that.

yuletide commented 5 years ago

So it seems shift-fader does literally nothing which is actually useful since you can reset the fader position to neutral without sending any signal. I just discovered it this last second which solved my problem of running out of fader room when set to relative and loading a new track with the fader already down

kokernutz commented 5 years ago

Ah yes, that's it. Still need a mapping to fix master tempo?