kokernutz / traktor-kontrol-screens

Replacement screens for the Native Instruments Traktor Kontrol D2, S5, and S8
102 stars 40 forks source link

Working on an update for 3.3.0 by any chance? #37

Closed amandryka closed 4 years ago

amandryka commented 4 years ago

Shows you how good your mod is when I'm freaking out with the default screens :)

HaryShanthi commented 4 years ago

Hey! Same request as "amandryka" if it would be possible to get a 3.3 version when your schedule allows as i miss ur mod. Thanks in advance

bertpatroons commented 4 years ago

+1

slsilvia commented 4 years ago

+1

MrPatben8 commented 4 years ago

+1

kokernutz commented 4 years ago

Sorry y'all! I was going to do it this weekend but got sidetracked with wine.

I'm going to try and live stream me updating my mods tonight! No more alcohol until the mods are updated. :)

MrPatben8 commented 4 years ago

@kokernutz I'll be tuning in :)

amandryka commented 4 years ago

Thanks! Anyone knows where are these streams happening?

Also @kokernutz where would you recommend I start learning about qml scripting for the S5?

kokernutz commented 4 years ago

follow me on twitter @kokernutz

or twitch.tv/kokernutz

i am not going to do it tonight (my day job sucked me in) but i did hook up my S5 to make sure that it still works and i am writing up an outline so i can do the livestream and make the changes as fast as i can. hopefully 30 minutes. 60 at most.

check back tomorrow!

kokernutz commented 4 years ago

Thanks! Anyone knows where are these streams happening?

Also @kokernutz where would you recommend I start learning about qml scripting for the S5?

I'll give a little overview, but if you've done any programming at all I'm confident you can figure it out easily. (It's javascript.)

MrPatben8 commented 4 years ago

Damn, I missed the live stream. Any idea when the update comes out? @kokernutz

kokernutz commented 4 years ago

I will work on it some more tomorrow... I was a little careless and f-ed something up.

MrPatben8 commented 4 years ago

Ah, alrighty then. Good luck!

MrPatben8 commented 4 years ago

So I tried my luck updating it myself and I think I've got it working. @kokernutz Here's a link to my pull request: https://github.com/kokernutz/traktor-kontrol-screens/pull/38

slsilvia commented 4 years ago

Is the 3.3.0 mod ready to roll?

MrPatben8 commented 4 years ago

@slsilvia Mine is, you can check out my fork here https://github.com/MrPatben8/traktor-kontrol-screens It should be working with Traktor 3.3.0 plus some extra fixes and features ~~I'm currently adding some extra features so I'd suggest waiting a little before downloading it. I'll let you guys know when it's done.~~ I've finished adding the new features. This mod has MixerFX selection for S8 and S5 units as well as some extra settings for course or fine tempo adjustment along with some minor fixes. You can modify these settings in the Prefs.qml file

Hopefully @kokernutz will approve some of the merge requests that I'll make for these extra features. That way we can just keep all of the features in one mod instead of having to use forks like mine.

yuletide commented 4 years ago

@MrPatben8 Tried your fork (3.3.0 update branch?) on my S4mk3 but I'm having weird oscillating sounds and the controller doesn't start up. Maybe I missed something?

MrPatben8 commented 4 years ago

@yuletide Hmm, that's strange. I have no explanation for the weird sounds, the mod should only modify the inputs (control surface) and the displays. As for the controller not starting up I'm not sure, perhaps I missed something in the update, but I did have a similar issue when I didn't copy all of the qml files correctly. Are you on Windows or MacOS?

yuletide commented 4 years ago

@MrPatben8 Just tried reinstalling by copying into /qml instead of replacing it but same issue (audio artifacts only happen when Master is set to 90%+). I'm on MacOS.

MrPatben8 commented 4 years ago

@yuletide I'll take a look at it tomorrow but I can't test anything since I just own an S8. I'll see if I maybe missed anything obvious. Although usually when something isn't right with the mod it usually just crashes Traktor, so this behavior you're experiencing is unusual.

MrPatben8 commented 4 years ago

@yuletide You could help me debugging. Install the mod except for the following files (keep the originals instead of replacing them):

Then one by one replace an original file with the modded version and restart Traktor until it no longer works, then let me know the last file that you replaced. This should help me pin-point where the issue is. The issue might be somewhere else but this is a good start.

slsilvia commented 4 years ago

@MrPatben8 any update on the bugs?

MrPatben8 commented 4 years ago

@slsilvia I believe most bugs have been fixed so the updated mod should be good to go, unless you are using an S4mk3. If you are, please follow my debug steps above and let me know what happens, that way I can solve those issues. You can find my fork here https://github.com/MrPatben8/traktor-kontrol-screens If you run into any other issues please let me know.

slsilvia commented 4 years ago

just downloaded the new qml build and nothing worked, not even the change to the desktop UI. additionally, when plugged in, my S4MK3 did not respond at all.

yuletide commented 4 years ago

Sorry I ended up installing the other mod (browse mode!) for a gig Friday so haven’t had time to bug fix this one. That thing is legit...

MrPatben8 commented 4 years ago

@slsilvia Are you downloading this mod or my fork? This mod is not working because it hasn't been updated yet. If you want the updated version of this mod you need to download my fork from here https://github.com/mrpatben8/traktor-kontrol-screens/

slsilvia commented 4 years ago

@MrPatben8 yeah, just download your fork. Changed the name of existing qml to qmlBackup, renamed your fork to qml, dropped it into the resources folder, opened Traktor and the waveforms/phase meter are still the same as default.

MrPatben8 commented 4 years ago

@slsilvia Is the rest of the mod working?

slsilvia commented 4 years ago

@MrPatben8 no. It would appear not.

kokernutz commented 4 years ago

I just updated my repo. Please give it a whirl and let me know if you run into any problems.

amandryka commented 4 years ago

Thanks, seems to be working on S5.